Fixes to structured report example and add additional secondary capture example #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2021 11:56
…saving 3D ct and seg that are in NumPy arrays
CPBridge
requested changes
Oct 21, 2021
There was a problem hiding this comment.
@delton137 thanks a lot for putting together this example and catching the bugs. I have made some suggestions, several involving bringing the code in line with PEP8, which we use throughout the library code.
CPBridge
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structured report example was missing some imports which I found I had to add to get it to run.
I also corrected 2 spelling mistakes and added an additional example showing how to save a CT and seg that are in 3D NumPy arrays to .dcm.