Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Issue #9 (Reorganizing dockerfiles and docker images CI/CD) #26

Merged
merged 40 commits into from
Oct 18, 2023
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
4a57b7c
added the argument (ARG) to dockerfiles
vkt1414 Sep 22, 2023
02f175c
Add .gitignore for dev branch
vkt1414 Sep 22, 2023
3867773
using env var instd of set-output as it is depcrtd
vkt1414 Sep 22, 2023
a0040fe
dev docker images, invoke gh actions whnevr wrkflw files are updated
vkt1414 Sep 22, 2023
9ba4c9c
added totalseg suffix to download_convert_inference file name for con…
vkt1414 Sep 22, 2023
67e634c
add download_convert_inference_totalseg.yml
vkt1414 Sep 22, 2023
861b06c
troublesshooting GIT_HASH
vkt1414 Sep 22, 2023
25630dd
corrected GIT_HASH variable
vkt1414 Sep 22, 2023
e406c78
corrected GIT_HASH variable
vkt1414 Sep 22, 2023
aa66767
corrected GIT_HASH variable
vkt1414 Sep 22, 2023
ac279e2
fixed referencing GIT HASH variable
vkt1414 Sep 22, 2023
b5c55c8
fixed referencing GIT HASH variable
vkt1414 Sep 22, 2023
c93e3b9
corrected path of dockerfile ref while building image
vkt1414 Sep 22, 2023
359090d
correct expected docker image in the label
vkt1414 Sep 22, 2023
ba13319
Update README.md
vkt1414 Sep 22, 2023
585b676
Create ReadMe.MD
vkt1414 Sep 22, 2023
3844e25
Update ReadMe.MD
vkt1414 Sep 22, 2023
3554d89
Update ReadMe.MD
vkt1414 Sep 22, 2023
efc1233
Update and rename ReadMe.MD to README.md
vkt1414 Sep 22, 2023
492cc70
created actions files for dev and main branches
vkt1414 Sep 22, 2023
47dea00
rectify trigger files for dev branches
vkt1414 Sep 22, 2023
b06eebf
rename actions names for dev to distinguish
vkt1414 Sep 22, 2023
9150654
fix docker image references in wdl files
vkt1414 Sep 22, 2023
807dbfb
fix docker image references in cwl files
vkt1414 Sep 22, 2023
7470516
considate dev and main branch workflows to one
vkt1414 Sep 22, 2023
5af3dac
Created using Colaboratory
vkt1414 Sep 22, 2023
002d8c3
test ghcr.io container registry
vkt1414 Sep 24, 2023
6e8eb14
add ghcr.io build and push steps to all
vkt1414 Sep 25, 2023
13dac0d
remove plastimatch from apt-package installation
vkt1414 Sep 26, 2023
c89ceb3
remove plastimatch from apt-get, use dcm2niix by default, upgrade s5cmd
vkt1414 Sep 26, 2023
b8f5468
add PR trigger to the workflow
fedorov Sep 27, 2023
a541cc5
simplify GA workflow
fedorov Sep 27, 2023
3a64510
simplify gihub actions workflow to main branch only
vkt1414 Sep 28, 2023
b235986
fix ga script--jobs
vkt1414 Sep 28, 2023
1cc82ea
rename radiomics to dicom_seg_pyradiomics_sr
vkt1414 Sep 28, 2023
91a1b47
rename radiomics to dicom_seg_pyradiomics_sr
vkt1414 Sep 28, 2023
a4446ae
rename radiomics to dicom_seg_pyradiomics_sr
vkt1414 Sep 28, 2023
71aea6d
Add docker builds status from github actions
vkt1414 Sep 28, 2023
d298e03
push docker images only on push events
vkt1414 Oct 2, 2023
434d7e5
push docker images only on push events
vkt1414 Oct 2, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 27 additions & 11 deletions .github/workflows/download_convert.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
name: download_convert

on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]


jobs:
build-and-push:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand All @@ -22,39 +25,52 @@ jobs:
COMMIT_HASH=$(git rev-parse HEAD)
echo "COMMIT_HASH=$COMMIT_HASH" >> $GITHUB_ENV

- name: Build Docker image
uses: docker/build-push-action@v5
with:
context: .
file: ./Dockerfiles/download_convert/Dockerfile
tags: imagingdatacommons/download_convert
build-args: |
GIT_HASH=${{ env.COMMIT_HASH }}
env:
COMMIT_HASH: ${{ env.COMMIT_HASH }}

push-dockerhub:
needs: build
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

runs-on: ubuntu-latest
steps:
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Build and push Docker image to Docker Hub
- name: Push Docker image to Docker Hub
uses: docker/build-push-action@v5
with:
context: .
file: ./Dockerfiles/download_convert/Dockerfile
push: true
tags: imagingdatacommons/download_convert
build-args: |
GIT_HASH=${{ env.COMMIT_HASH }}
env:
COMMIT_HASH: ${{ env.COMMIT_HASH }}

push-ghcr:
needs: build
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
steps:
- name: Login to GitHub Container Registry (ghcr.io)
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push Docker image to GitHub Container Registry
- name: Push Docker image to GitHub Container Registry
uses: docker/build-push-action@v5
with:
context: .
file: ./Dockerfiles/download_convert/Dockerfile
push: true
tags: ghcr.io/imagingdatacommons/download_convert
build-args: |
GIT_HASH=${{ env.COMMIT_HASH }}
env:
COMMIT_HASH: ${{ env.COMMIT_HASH }}
Loading