Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: 1.3.0-floweditor-1.18.4 #29

Merged
merged 51 commits into from
May 22, 2024
Merged

Commits on Oct 13, 2022

  1. Configuration menu
    Copy the full SHA
    4fddb11 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. adding dial and call limit to advanced tab in progress

    - added a bit of styling to the advanced tab
    - added dial limit and call limit to the advanced tab
    - added dial limit and call limit to the wait JSON
    susanm74 committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    dff30e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. unit tests in progress

    - updated existing unit test snapshot
    - added placeholders for unit tests
    susanm74 committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    02a9643 View commit details
    Browse the repository at this point in the history
  2. some updates to ui

    - fixed call limit handler method typo
    - added placeholder to each text input
    - minor update to position of __className in list of elem attrs
    - added todo's to scss
    susanm74 committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ad39459 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. saving dialLimit and callLimit values in progress

    - removed extra unused style rules (but keeping style file for now)
    - using vanilla p element instead of TextInputElement showLabel attribute for dialLimit and callLimit textbox labels
    - removed unused TextInputElement __className attribute
    - added dialLimit and callLimit to helpers nodeToState?
    - added dialLimit and callLimit to flowTypes wait interface?
    susanm74 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    9fe27cd View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. dialLimit and callLimit saving and displaying correct, unit tests in …

    …progress
    
    - removed extra comments in dial router form
    - explicitly setting dialLimit and callLimit to themselves in setState
    - switched setting dialLimit and callLimit from "StringEntry = { value: '' }" to just "" in nodeToState
    - switched setting dialLimit from router.wait.dialLimit to router.wait.dial_limit in nodeToState
    - switched setting callLimit from router.wait.callLimit to router.wait.call_limit in nodeToState
    - no changes needed to const wait in stateToNode
    - unit tests in progress
    susanm74 committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    f6b67c6 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Configuration menu
    Copy the full SHA
    7962833 View commit details
    Browse the repository at this point in the history
  2. updates based on review, testing in progress

    - added explicit defaults for dialLimit and callLimit
    - switched from StringEntry to NumberEntry
    - unit tests in progress
    susanm74 committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    9f364fc View commit details
    Browse the repository at this point in the history
  3. Merge branch 'sl-dial-router-form-advanced-tab' of https://github.com…

    …/nyaruka/floweditor into sl-dial-router-form-advanced-tab
    susanm74 committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    2404035 View commit details
    Browse the repository at this point in the history
  4. more updates based on review

    - switched from string to number
    - removed extra casting/conversion
    susanm74 committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    36b8d4c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. added unit tests for dial_limit and call_limit

    - added tests for dial limit and call limit
    - removed i18n.t() from TextInputElement name attr value
    - updated createDialRouter to add dialLimit and callLimit args
    - updated snapshot
    susanm74 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    055a2dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1154995 View commit details
    Browse the repository at this point in the history
  3. fixed rule translations tab bug, unit test in progress

    - fixed originalArgument var name typo
    - fixed bug where rule translations tab wasn't displaying "has number between" arguments correctly
    susanm74 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    759b3bf View commit details
    Browse the repository at this point in the history
  4. minor update to test name

    susanm74 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    c061181 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. fixed rule translations saving empty strings as translations: [""]

    - added truthy filter to kase.arguments just before the check for any kase.arguments
    susanm74 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    cfcf4da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a3f9dc View commit details
    Browse the repository at this point in the history
  3. updated tests and snapshot

    susanm74 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    8baecda View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3d0a310 View commit details
    Browse the repository at this point in the history
  5. initial work on adding skip contacts in a flow checkbox to start some…

    …one else in a flow form
    susanm74 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    b5a22e7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4787e84 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. updates based on using simple boolean for checkbox

    - switched from temba-checkbox to CheckboxElement
    - added update logic for skipContactsInFlow in StartSessionForm handleUpdate fn
    - added init logic for skipContactsInFlow in helpers initializeForm fn
    - added skipContactsInFlow to helpers stateToAction fn's action object
    - added skipContactsInFlow to flowTypes StartSession interface
    - added skipContactsInFlow to assetCreators createStartSessionAction
    susanm74 committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    ef11414 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Configuration menu
    Copy the full SHA
    92a59bf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9df9183 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Configuration menu
    Copy the full SHA
    b107699 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03858c2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3e90e95 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    773beff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8397577 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d5e2b45 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Configuration menu
    Copy the full SHA
    b258961 View commit details
    Browse the repository at this point in the history
  2. working end to end with a simple boolean

    - also moved checkbox into advanced tab
    susanm74 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    d6162af View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. switched from simple boolean to JSON object containing boolean

    - tentatively created ExclusionsCheckboxEntry to abstract and DRY things out a bit
    - updated unit tests
    susanm74 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    035fc50 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Merge pull request nyaruka#1082 from nyaruka/sl-has-number-between-bu…

    …gfix
    
    wait for response form - numeric rule - rule translations tab - has number between and empty translations bugfixes
    ericnewcomer authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    028b14b View commit details
    Browse the repository at this point in the history
  2. Merge pull request nyaruka#1083 from nyaruka/sl-start-somebody-else-s…

    …kip-support
    
    start somebody else in a flow form - add skip contacts in a flow checkbox
    ericnewcomer authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    abed310 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9c57f38 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f213a3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0ea169d View commit details
    Browse the repository at this point in the history
  6. Fix flex class name

    ericnewcomer committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    62cf6fc View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. wrapped dial and call limit as flex items in a flex container

    - added margin and width styling to flex items
    susanm74 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    c18dd88 View commit details
    Browse the repository at this point in the history
  2. removed first child's margin-left and last child's margin-right

    - now only adding margin-right to first child
    - now only adding margin-left to last child
    susanm74 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    91d414e View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. switched from using width: 100% in favor of using flex-grow: 1

    - and also added back the generic .flex_items margins in case we ever add anything in between the first and last child and need those items to maintain the same margins
    susanm74 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    b203c72 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Merge pull request nyaruka#1080 from nyaruka/sl-dial-router-form-adva…

    …nced-tab
    
    dial router form - new advanced tab with dial limit and call limit values
    ericnewcomer authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    80b7b47 View commit details
    Browse the repository at this point in the history
  2. Merge pull request nyaruka#1085 from nyaruka/sl-exclude-numerical-rul…

    …es-from-translations
    
    excluding all date, time, and numeric rules from translations
    ericnewcomer authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    b016068 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Configuration menu
    Copy the full SHA
    c4e04c6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request nyaruka#1089 from nyaruka/start-session-no-group

    Disallow groups on start session action
    ericnewcomer authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    26ce47f View commit details
    Browse the repository at this point in the history
  3. v1.18.3

    ericnewcomer committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    bf9ff0c View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Configuration menu
    Copy the full SHA
    64262f5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request nyaruka#1091 from nyaruka/fix-start-session

    Fix StartSessionForm bug for definitions without exclusions
    ericnewcomer authored Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f7200c8 View commit details
    Browse the repository at this point in the history
  3. v1.18.4

    ericnewcomer committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0469111 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    3c6f63d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9103c6c View commit details
    Browse the repository at this point in the history