Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggiunta capitolo DDD #227

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Aggiunta capitolo DDD #227

wants to merge 11 commits into from
+208 −0

Conversation

baldarn
Copy link

@baldarn baldarn commented May 10, 2024

Vedi
#226

@baldarn
Copy link
Author

baldarn commented May 14, 2024

@BrianAtzori @Cadienvan wdyt?

@baldarn baldarn marked this pull request as ready for review May 14, 2024 09:18
BrianAtzori
BrianAtzori requested changes May 18, 2024
View reviewed changes
Copy link
Member

@BrianAtzori BrianAtzori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per me il contenuto è buono, c'`e solo qualche errorino da sistemare ma a me fila ed è tutto chiaro!
Lascio la parola anche ad altri ambassador che hanno una seniority piu' navigata rispetto alla mia per un giudizio sui contenuti, ma per me hai prodotto un bel testo, bravo!

docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
@Cadienvan
Copy link
Member

Non sono sparito! Ahah sabato prossimo mi sono preso un momento per leggere come si deve il contenuto! Scusatemi ma tra mille impegni e tutti i capitoli in corso devo sdoppiarmi!

@baldarn baldarn requested a review from BrianAtzori May 20, 2024 08:54
Cadienvan
Cadienvan reviewed May 27, 2024
View reviewed changes
Copy link
Member

@Cadienvan Cadienvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il contenuto mi torna, farei una introduzione più approfondita del contesto in cui spicca il DDD e il perché dovrei considerare l'adozione di questa metodologia nella mia quotidianità. Considerando il target entry-level del libro, ho paura che si perda il "perché", mentre il "cosa" è piuttosto chiaro e ben definito!

BrianAtzori
BrianAtzori previously approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@BrianAtzori BrianAtzori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mi torna tutto!
Come sempre passo la palla a qualche ambassador più navigato per un'ulteriore conferma ma secondo me ci siamo, ho visto che hai approvato anche i change che ti ho suggerito quindi top, grande! 🙌🏻

@Cadienvan
Copy link
Member

Ciao @baldarn cosa ne pensi del mio suggerimento sull'intro esplicativa?

@baldarn
Copy link
Author

baldarn commented Jun 26, 2024

@Cadienvan ho scritto una breve intro con pro e contro, se è ok mergiamo, poi arriverà gente che aggiungerà/toglierà cose, io sono solo un dilettante XD

BrianAtzori
BrianAtzori requested changes Jun 26, 2024
View reviewed changes
docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
@baldarn baldarn requested a review from BrianAtzori June 27, 2024 08:59
Cadienvan
Cadienvan previously approved these changes Jul 9, 2024
View reviewed changes
@baldarn baldarn dismissed stale reviews from BrianAtzori and Cadienvan via 27c545d August 17, 2024 15:12
Cadienvan
Cadienvan previously approved these changes Aug 17, 2024
View reviewed changes
AngeloAvv
AngeloAvv previously approved these changes Aug 19, 2024
View reviewed changes
guizzo
guizzo previously approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@guizzo guizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baldarn A me sembra un buon contenuto 👍

Ho aggiunto qualche suggestions ma sentiti libero di valutare tu stesso se è il caso o meno di introdurle all'interno del capitolo.

In ogni caso ti approvo la review, ottimo lavoro 💪

docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
docs/it/domain-driven-design.md Outdated Show resolved Hide resolved
@baldarn baldarn dismissed stale reviews from guizzo, AngeloAvv, and Cadienvan via 444445c August 23, 2024 08:01
baldarn and others added 11 commits August 23, 2024 10:01
@Cadienvan Cadienvan linked an issue Sep 7, 2024 that may be closed by this pull request
[🆕]: Domain Driven Design #226
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadienvan Cadienvan Cadienvan approved these changes

@AngeloAvv AngeloAvv AngeloAvv approved these changes

@guizzo guizzo guizzo approved these changes

@BrianAtzori BrianAtzori BrianAtzori approved these changes

@eppak eppak Awaiting requested review from eppak

@EMCestari EMCestari Awaiting requested review from EMCestari

@davideimola davideimola Awaiting requested review from davideimola

@serenasensini serenasensini Awaiting requested review from serenasensini

@manuelricci manuelricci Awaiting requested review from manuelricci

@giuppidev giuppidev Awaiting requested review from giuppidev

@akelity akelity Awaiting requested review from akelity

@fulgido fulgido Awaiting requested review from fulgido

@devnuli devnuli Awaiting requested review from devnuli

@corradopetrelli corradopetrelli Awaiting requested review from corradopetrelli

@elgorditosalsero elgorditosalsero Awaiting requested review from elgorditosalsero

@imD3v imD3v Awaiting requested review from imD3v

At least 6 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: In Revisione
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🆕]: Domain Driven Design
5 participants
@baldarn @Cadienvan @AngeloAvv @guizzo @BrianAtzori