Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggiunge Mutation al capitolo sul testing #215

Merged
merged 12 commits into from
May 4, 2024
Merged

Aggiunge Mutation al capitolo sul testing #215

merged 12 commits into from
May 4, 2024

Conversation

Cadienvan
Copy link
Member

Come da titolo, ho aggiunto il mutation testing che spesso viene trascurato quando si parla del mondo dei test.

AngeloAvv
AngeloAvv previously approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@AngeloAvv AngeloAvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sembra la trama di un film sci-fi

allevo
allevo reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Varrebbe la pena aggiungere una nota per cui lo score non ha senso che sia al 100%?
Avrebbe senso dare un numero indicativo dello score?

docs/it/testing.md Outdated Show resolved Hide resolved
docs/it/testing.md Outdated Show resolved Hide resolved
docs/it/testing.md Outdated Show resolved Hide resolved
@Cadienvan @allevo
chore: revisione
f1d8cde 
Co-authored-by: Tommaso Allevi <[email protected]>
@Cadienvan
Copy link
Member Author

Ciao @allevo ,
tutte giuste le osservazioni fatte, le ho portate dentro!

Riguardo al "100%".. Magari una aggiunta alla sezione sotto, "Test Coverage", in cui diciamo che anche per il mutation non necessariamente serve averlo al 100%?

@allevo
Copy link
Contributor

allevo commented Feb 13, 2024

@Cadienvan il test coverage non fa parte dei mutation tests. Il code coverage indica per quale riga passa quale test. Qui è "il contrario": quale test si rompe per quale riga. Secondo me crea confusione nel lettore mettere tutto assieme.

@Cadienvan
Copy link
Member Author

Ok @allevo , sì, mi torna!

Hai una idea per buttarlo giù?

allevo
allevo reviewed Feb 19, 2024
View reviewed changes
docs/it/testing.md Outdated Show resolved Hide resolved
guizzo
guizzo reviewed Feb 20, 2024
View reviewed changes
docs/it/testing.md Outdated Show resolved Hide resolved
BrianAtzori
BrianAtzori requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@BrianAtzori BrianAtzori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come sezione é ok e a parte l'introduzione che é da rivedere forse, mi sembra che arrivi in modo chiaro il concetto da esprimere 😊

docs/it/testing.md Outdated Show resolved Hide resolved
BrianAtzori
BrianAtzori previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@BrianAtzori BrianAtzori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci siamo! Per me é ok (Ero convinto di aver giá fatto la review 🤷🏻‍♂️)

sensorario
sensorario previously approved these changes Mar 15, 2024
View reviewed changes
@Cadienvan
Copy link
Member Author

Colpa di @corradopetrelli che ha chiesto modifiche ahahahah

@corradopetrelli
Copy link
Member

Colpa di @corradopetrelli che ha chiesto modifiche ahahahah

Prego

serenasensini
serenasensini reviewed Mar 16, 2024
View reviewed changes
docs/it/testing.md Outdated Show resolved Hide resolved
docs/it/testing.md Outdated Show resolved Hide resolved
lmammino
lmammino previously approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@lmammino lmammino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approvato con qualche piccolo consiglio :)

docs/it/testing.md Outdated Show resolved Hide resolved
docs/it/testing.md Show resolved Hide resolved
giuppidev
giuppidev approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@giuppidev giuppidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onestamente non conoscevo bene il mutation testing e dal capitolo mi è stato introdotto perfettamente. Complimenti!

serenasensini
serenasensini reviewed May 4, 2024
View reviewed changes
Copy link
Member

@serenasensini serenasensini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per me, super ok le correzioni già presenti!

@Cadienvan Cadienvan merged commit 7d1a7c7 into main May 4, 2024
2 checks passed
@Cadienvan Cadienvan deleted the patch/testing branch May 4, 2024 18:59
akelity
akelity approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@akelity akelity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direi ottimo!

eppak pushed a commit that referenced this pull request Jul 22, 2024
@Cadienvan @allevo
@corradopetrelli @serenasensini @lmammino @eppak
Aggiunge Mutation al capitolo sul testing (#215)
581573c 
Co-authored-by: Tommaso Allevi <[email protected]>
Co-authored-by: Corrado Petrelli <[email protected]>
Co-authored-by: Serena Sensini <[email protected]>
Co-authored-by: Luciano Mammino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenasensini serenasensini serenasensini left review comments

@BrianAtzori BrianAtzori BrianAtzori approved these changes

@akelity akelity akelity approved these changes

@giuppidev giuppidev giuppidev approved these changes

@davideimola davideimola davideimola approved these changes

@AngeloAvv AngeloAvv AngeloAvv approved these changes

@lmammino lmammino lmammino approved these changes

@christiancannata christiancannata Awaiting requested review from christiancannata

@EMCestari EMCestari Awaiting requested review from EMCestari

@devnuli devnuli Awaiting requested review from devnuli

@elgorditosalsero elgorditosalsero Awaiting requested review from elgorditosalsero

@guizzo guizzo Awaiting requested review from guizzo

@allevo allevo Awaiting requested review from allevo

@corradopetrelli corradopetrelli Awaiting requested review from corradopetrelli

@sensorario sensorario Awaiting requested review from sensorario

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.