-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggiunge automazione per formattare il codice prima di ogni commit #115
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9cbd89c
chore: Add pre-commit code format
guizzo 52f8795
chore: Add dependency
guizzo f84f43b
chore: Rename npm script
guizzo dd79b29
chore: Add command on npm scripts
guizzo fe7462b
refactor: rimosso husky, introdotto lefthook
elgorditosalsero 0748475
fix: CONTRIBUTING
elgorditosalsero c21e2f2
fix: gha format
elgorditosalsero 7d7d734
fix: Format GHA
elgorditosalsero cfb9225
feat: aggiunto format:check al pre-push
elgorditosalsero f5b60f0
fix: rimosso comando prepare
elgorditosalsero e161f21
fix: comando formattazione in CONTRIBUTING.md
elgorditosalsero f985e7e
Aggiunto conventional commit (#131)
elgorditosalsero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
18.18.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
colors: true | ||
pre-commit: | ||
commands: | ||
prettier: | ||
glob: "*.md" | ||
run: npm run format:write {staged_files} | ||
pre-push: | ||
commands: | ||
format-check: | ||
glob: "*.md" | ||
run: npm run format:check | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,10 @@ | ||
{ | ||
"scripts": { | ||
"format": "prettier --write ." | ||
"format:check": "npx prettier --check \"**/*.md\"", | ||
"format:write": "prettier --write" | ||
}, | ||
"devDependencies": { | ||
"lefthook": "^1.5.0", | ||
"prettier": "^3.0.2" | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggerimento: Non utilizzerei
npx
per avviare Prettier avendolo già installato nelle dipendenze.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, credo che sia stato inserito per evitare di installare le
devDeps
direttamente dalla action. È strettamente necessario secondo voi?Personalmente "normalizzerei" gli scripts in maniera tale che vengano tutti avviati in un'unica maniera.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Al momento è l'unica action che abbiamo e che ha bisogno di
node
.Volendo si può rimuovere
node
e lanciare il comando a mano, ma poi se si cambia nel package.json andrebbe cambiato anche nella actions.Sinceramente non installerei le deps e non le metterei nemmeno in cache, o almeno, non al momento.