Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggiunge automazione per formattare il codice prima di ogni commit #115
Aggiunge automazione per formattare il codice prima di ogni commit #115
Changes from 9 commits
9cbd89c
52f8795
f84f43b
dd79b29
fe7462b
0748475
c21e2f2
7d7d734
cfb9225
f5b60f0
e161f21
f985e7e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggerimento: Non utilizzerei
npx
per avviare Prettier avendolo già installato nelle dipendenze.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, credo che sia stato inserito per evitare di installare le
devDeps
direttamente dalla action. È strettamente necessario secondo voi?Personalmente "normalizzerei" gli scripts in maniera tale che vengano tutti avviati in un'unica maniera.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Al momento è l'unica action che abbiamo e che ha bisogno di
node
.Volendo si può rimuovere
node
e lanciare il comando a mano, ma poi se si cambia nel package.json andrebbe cambiato anche nella actions.Sinceramente non installerei le deps e non le metterei nemmeno in cache, o almeno, non al momento.