Skip to content

Update keyboard navigation topic for React 19 #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: vnext
Choose a base branch
from

Conversation

MarielaTihova
Copy link
Contributor

No description provided.

Copy link
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there is some missing text in the Custom keyboard navigation in WC because of your changes

grid.data = this.data
grid.addEventListener("gridKeydown", this.customKeydown);
grid.addEventListener("onGridKeydown", this.customKeydown);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event for WC is still gridKeydown

const target= detail.target;
const evt = detail.event;
const type = detail.targetType;
const customKeydown = (eventArgs: IgrGridKeydownEventArgs) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this snippet is for React only since in WC the components are classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants