Skip to content

Update filtering topic for React 19 #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: vnext
Choose a base branch
from

Conversation

MarielaTihova
Copy link
Contributor

No description provided.

@mddragnev mddragnev self-requested a review May 9, 2025 11:40
Copy link
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are couple of snippets where this keyword is used. We should show snippets with functional components code. Could you remove those?

Also, there is a typo here To enable the [Advanced filtering](http://localhost:3000/components/grids/grid/advanced-filtering.html) however, you need to set the [allowAdvancedFiltering](https://staging.infragistics.com/products/ignite-ui-react/api/docs/typescript/latest/classes/igniteui_react_grids.igrgridbasedirective.html#allowAdvancedFiltering) input property to true.7 at the end there is a number 7.

Also, could you refactor the Initial filtered state snippet so that it uses functional components style. Please, make sure that there is no type casting. It could look as clean as:

  const filteringExpressionTree: IgrFilteringExpressionsTree = {
    operator: FilteringLogic.And,
    filteringOperands: [
      {
        fieldName: "ProductID",
        conditionName: "equals",
        ignoreCase: true,
        searchVal: 1,
      },
    ],
  };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants