Skip to content

Update column pinning topic for React 19 #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: vnext
Choose a base branch
from

Conversation

IMinchev64
Copy link
Contributor

No description provided.

@mddragnev mddragnev self-requested a review May 8, 2025 10:21
Copy link
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. At the snippet showing the columnPinning event handler - could you set the argument type?
  2. Pinning position is no longer a class but a type so PinningPosition should be set like this:
  const pinning: IgrPinningConfig = { columns: ColumnPinningPosition.End };

@IMinchev64 IMinchev64 added the status: awaiting-test ❌ PR ready for testing label May 12, 2025
@IMinchev64 IMinchev64 requested a review from mddragnev May 12, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting-test ❌ PR ready for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants