Skip to content

Update collapsible column groups topic for React 19 #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 12, 2025
Merged

Update collapsible column groups topic for React 19 #1506

merged 5 commits into from
May 12, 2025

Conversation

IMinchev64
Copy link
Contributor

No description provided.

mddragnev
mddragnev requested changes May 7, 2025
View reviewed changes
Copy link
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change all properties that are boolean to accept a boolean value and not a string:
visibleWhenCollapsed="false" becomes visibleWhenCollapsed={false}

@IMinchev64 IMinchev64 requested a review from mddragnev May 8, 2025 14:08
@IMinchev64 IMinchev64 added the status: awaiting-test ❌ PR ready for testing label May 8, 2025
mddragnev
mddragnev previously approved these changes May 9, 2025
View reviewed changes
@dkamburov dkamburov added status: verified ✅ The PR is tested and ready for a merge and removed status: awaiting-test ❌ PR ready for testing labels May 12, 2025
@dkamburov dkamburov requested a review from mddragnev May 12, 2025 13:01
@dkamburov dkamburov merged commit 2a60d0f into vnext May 12, 2025
11 checks passed
@dkamburov dkamburov deleted the iminchev/collapsible-column-groups-react branch May 12, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkamburov dkamburov dkamburov approved these changes

@mddragnev mddragnev Awaiting requested review from mddragnev

Assignees

@dkamburov dkamburov

Labels
status: verified ✅ The PR is tested and ready for a merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IMinchev64 @dkamburov @mddragnev