Skip to content

Update Finjs sample to work with react19 #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: v19-updates
Choose a base branch
from
Open

Update Finjs sample to work with react19 #775

wants to merge 3 commits into from

Conversation

MarielaTihova
Copy link
Contributor

@MarielaTihova MarielaTihova commented May 5, 2025 •
edited
Loading

  1. Fixed:

    1. Stop button. It was always showing as disabled
    2. Price column: colors were not visible
    3. Sliders: sliding didn't change the value

  2. Cleanup and refactoring

    1. Removed unused imports
    2. Ordered code
    3. Got rid of some useRef usage
    4. Icons setup

  3. What is left? (UPDATE: Resolved both issues with commit 5f235df)

    1. Chart in grid. Currently not showing because there is no field="chart"
    2. Slider initial state issue. Initial state is always 100 even if another value is set in the useState. Is this a known issue/bug and is there a workaround for it? It's not working in the old react version of the finjs sample either.

@MarielaTihova MarielaTihova mentioned this pull request May 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dkamburov dkamburov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarielaTihova @dkamburov