Fix 'proto' operation #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbara
reviewed
Sep 23, 2016
| @@ -1236,6 +1236,10 @@ function selftest () | |||
| expand(parse("ether[0] = 2"), 'EN10MB')) | |||
| assert_equals(expand(parse("src 1::ff11"), 'EN10MB'), | |||
| expand(parse("src host 1::ff11"), 'EN10MB')) | |||
| assert_equals(expand(parse("proto sctp"), 'EN10MB'), | |||
| expand(parse("ip proto sctp or ip6 proto sctp"), 'EN10MB')) | |||
There was a problem hiding this comment.
This is slightly wrong, if we're going for libpcap language compatibility.
% sudo tcpdump -d -ni wlan0 'ip proto tcp'
tcpdump: syntax error
% sudo tcpdump -d -ni wlan0 'ip proto \tcp'
(000) ldh [12]
(001) jeq #0x800 jt 2 jf 5
(002) ldb [23]
(003) jeq #0x6 jt 4 jf 5
(004) ret #262144
(005) ret #0
There was a problem hiding this comment.
Ah, thanks, I should've put backslashes on those in the test. (pflua already seems to accept either backslash or none to begin with on these)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like at some point the
protooperation broke in pflua. I've added some tests for it and added a fix.This also updates the
proto \sctpexample. I was less sure about this part so please let me know if I didn't do the update quite right.Related to issue #255