Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpewebkit: Enable QtWPE build support for Qt6 for 2.46.0 #506

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

wpewebkit: Enable QtWPE build support for Qt6 for 2.46.0 #506

wants to merge 1 commit into from

Conversation

Qingwu-Li
Copy link

@Qingwu-Li Qingwu-Li commented Sep 6, 2024 •
edited
Loading

Tested with QT6 build

know issue：
gcc 11 may failed build neon.h failed for arm64, see Qingwu-Li/WebKit@176cb80

@Qingwu-Li
Copy link
Author

@pabelenda Please do a review!

@Qingwu-Li Qingwu-Li marked this pull request as ready for review September 6, 2024 09:19
@psaavedra
Copy link
Member

Hi @Qingwu-Li, thank you for the PR. We really appreciate all contributions to the project. I have a few comments regarding the pull request:

  • 2.45.x is not a stable WPE release. Odd-numbered versions refer to development releases. I suggest adjusting the wpewebkit bump to version 2.44.4. Please note that this PR already handles the bump to 2.44.4.
  • Is Qt6 WPE not yet supported in 2.44? If that is the case, we could consider adding support for 2.45 as an exception, but with DEFAULT_PREFERENCE = "-1" in the recipe.

@Qingwu-Li
Copy link
Author

  • Is Qt6 WPE not yet supported in 2.44? If that is the case, we could consider adding support for 2.45 as an exception, but with DEFAULT_PREFERENCE = "-1" in the recipe.

Hello @psaavedra , yes Qt6 WPE not supported in 2.44,
Change in V2:
Add DEFAULT_PREFERENCE = "-1"
Fix the gcc 11(kirkstone) build simd failed issue.

@aperezdc
Copy link
Member

We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some weeks.

@psaavedra
Copy link
Member

We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some weeks.

This PR (#509) will move the WPE version to 2.46. I could be very happy to integrate your changes after this 509 is merged if you make the adaptations in this 506 PR.

@Qingwu-Li Qingwu-Li marked this pull request as draft September 26, 2024 10:03
@Qingwu-Li Qingwu-Li changed the title wpewebkit: Bump to version 2.45.3 and add qt6 wpewebkit: Enable QtWPE build support for Qt6 Sep 27, 2024
@Qingwu-Li Qingwu-Li changed the title wpewebkit: Enable QtWPE build support for Qt6 wpewebkit: Enable QtWPE build support for Qt6 for 2.46.0 Sep 27, 2024
@psaavedra
Copy link
Member

We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some weeks.

This PR (#509) will move the WPE version to 2.46. I could be very happy to integrate your changes after this 509 is merged if you make the adaptations in this 506 PR.

#509 is ready and landed. Let's trigger the Actions for this PR.

psaavedra
psaavedra reviewed Oct 16, 2024
View reviewed changes
recipes-browser/wpewebkit/wpewebkit-qt6.inc

CMAKE_QT_OECONF = "\
-DUSE_QT6=ON \
-DENABLE_WPE_PLATFORM=ON \
Copy link
Member

@psaavedra psaavedra Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really needed (cc: @aperezdc )?

Copy link
Member

@aperezdc aperezdc Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the Qt6 integration uses WPEPlatform. In this case it's okay to rely on it even when its API is not yet considered stable becayse the Qt6 integration is also in the WebKit tree and the expectation is that we would keep it working alongside changes done to WPEPlatform.

Also, only the base ENABLE_WPE_PLATFORM=ON is needed, the rest of the ENABLE_WPE_PLATFORM_{DRM,WAYLAND,..} options can be OFF.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aperezdc if I set as

ENABLE_WPE_PLATFORM=ON
ENABLE_WPE_PLATFORM_DRM=OFF
ENABLE_WPE_PLATFORM_HEADLESS=OFF
ENABLE_WPE_PLATFORM_WAYLAND=OFF

I got folowing errors

Source/WebKit/WPEPlatform/wpe/WPEBufferSHM.cpp:29:10: fatal error: WPEEnumTypes.h: No such file or directory
|    29 | #include "WPEEnumTypes.h"
|       |          ^~~~~~~~~~~~~~~~

It seems need at lease set on of then to ON
Keep those on as default?

@psaavedra psaavedra self-assigned this Oct 16, 2024
@psaavedra psaavedra added this to the 202404_5.0_scarthgap milestone Oct 16, 2024
@Qingwu-Li
wpewebkit: Enable QtWPE build support for Qt6
8112414 
Refactor Qt configurations into separate files to
accommodate Qt5 and Qt6 based on BBFILE_COLLECTIONS.

Signed-off-by: LI Qingwu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psaavedra psaavedra psaavedra left review comments

@aperezdc aperezdc aperezdc left review comments

Assignees

@psaavedra psaavedra

Labels
enhancement
Projects
None yet
Milestone
202404_5.0_scarthgap
Development

Successfully merging this pull request may close these issues.
3 participants
@Qingwu-Li @psaavedra @aperezdc