x11: Do not attempt to set an invalid cursor #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also includes the changes from #672 but I can rebase it on top of |
psaavedra
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
LGTM. I spent a bit more time because I have to learn about WebKitHitTestResult and how this work to identify the type of HTML clicked or interacted elements.
I appreciate also the restructuration done in the first commit. The creation of the platform/common/cog-cursors.c and the encapsulation of the cursos types fixes should fix also an annoying build warning due to an unused definition.
r+
Only set the cursor when the resolved cursor is not XCB_CURSOR_NONE.
aperezdc
force-pushed
the
aperezdc/x11-fix-no-cursor
branch
from
43c9fee
to
0a8d14d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only set the cursor when the resolved cursor is not
XCB_CURSOR_NONE.