Add CogView::cog_view_[set|is]_visible() accessors #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psaavedra
force-pushed
the
psaavedra/cog_view_set_and_is_visible
branch
2 times, most recently
from
cdb324d
to
cec52df
Compare
aperezdc
requested changes
Nov 23, 2023
There was a problem hiding this comment.
I agree on the idea for the new API, but I have a few change requests. If you look into them, I think we can merge this today. Thanks @psaavedra! 🙏🏼
Gets if the view is visible inside of the viewport where the view is attached. Returns: True if the view is visible in its viewport and false in any other case.
psaavedra
force-pushed
the
psaavedra/cog_view_set_and_is_visible
branch
from
f15cf34
to
deac0b9
Compare
Set the view as the one visible inside of the viewport where the view is attached.
psaavedra
force-pushed
the
psaavedra/cog_view_set_and_is_visible
branch
from
deac0b9
to
912d136
Compare
Done. |
aperezdc
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add convenient accessors to the "visible" property the to the CogView external API:
CogView::cog_view_set_visible()sets the view as the one visible inside of the viewport where the view is attached.CogView::cog_view_is_visible()gets if the view is visible inside of the viewport where the view is attached.