Fix build with using glib<2.63.1 #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GLIB_CHECK_VERSION to verify if we really can use the g_warning_once and avoid the undefined reference to g_warning_once link error.
psaavedra
force-pushed
the
psaavedra/fix_warning_once_with_old_glib
branch
from
a8c996e
to
b849e83
Compare
aperezdc
reviewed
Nov 7, 2023
| @@ -125,9 +125,19 @@ cog_platform_init_web_view (CogPlatform *platform, | |||
| CogPlatformClass *klass = COG_PLATFORM_GET_CLASS(platform); | |||
| if (klass->init_web_view) { | |||
| if (klass->get_view_type) { | |||
| #if GLIB_CHECK_VERSION(2, 63, 1) | |||
There was a problem hiding this comment.
GLib 2.63.1 was released in October 2019. That's more than four years ago... so now I am wondering in which environment this is a problem.
I suggest we add a check in the top-level meson.build file to make sure the GLib version is new enough.
There was a problem hiding this comment.
On Yocto Dunfell with long time support until April of 2024 [ref] so you could expect this issue affecting to environments still supported in meta-webkit. If you think this is not a good argument, I could move it as an adaptation patch inside meta-webkit.
There was a problem hiding this comment.
Ahm, fair. Let's merge this and bump the GLib dependency in the next cycle after March-April 2024.
aperezdc
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GLIB_CHECK_VERSION to verify if we really can use the g_warning_once and avoid the undefined reference to g_warning_once link error.