Merge upstream main #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Expose Score enum. * Derive serde traits for Score. * Prefer u8 for Score conversion. * Add TryFrom<u8> implementation for Score. * Tweak TryFrom error message. Include a bit more context. * Improve doc comment. * Ensure Score serde uses numeric value.
* Add support for injecting unix millisecond time function for non-JS WASM targets * Cleanup dependencies in WASM targets * Rename feature for better conveying the intention * Run cargo fmt and add getrandom as dev dependency * Revert feature conditional cfg in tests * Make sure wasm-pack only runs features that are compatible with wasm-bindgen --------- Co-authored-by: AndyTitu <[email protected]>
Addresses #74. This is a non-backward compatible change, as the commit changes `Pattern.sequence_name` and `RegexPattern.regex_name` from `&'static str` to `String` in order to avoid static bounds during deserialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.