Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csv): fix #5279 always force subject to be a string in str_replace #5282

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Yoda-BZH
Copy link
Contributor

When performing a str_replace, subject should always be a string. If passing a non-existent column or empty column, subject may be null

This ensure str_replace is called when subject is actually a string (not NULL)

Copy link

cla-bot bot commented Oct 31, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Yoda-BZH.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

When performing a str_replace, subject should always be a string. If
passing a non-existent column or empty column, subject may be null

This ensure str_replace is called when subject is actually a string (not
NULL)
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nilmerg nilmerg added bug Something isn't working area/export Affects print/export functionality area/cli Affects the command line (icingacli) labels Nov 4, 2024
@nilmerg nilmerg added this to the 2.12.2 milestone Nov 4, 2024
@nilmerg nilmerg merged commit 41a2aed into Icinga:main Nov 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Affects the command line (icingacli) area/export Affects print/export functionality bug Something isn't working cla/signed
Projects
None yet
2 participants