Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #4789. Sort roles in by name #5008

Closed

Conversation

w1ll-i-code
Copy link

Add a column 'name' with the name of the role to the role array so that it is possible to sort the roles by name.

@cla-bot
Copy link

cla-bot bot commented Feb 22, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: William Calliari.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@w1ll-i-code
Copy link
Author

Hi, is there something missing for this PR? please let me know so I can fix it in case.

@nilmerg
Copy link
Member

nilmerg commented Sep 7, 2023

For a start, a signed CLA ;)

@nilmerg
Copy link
Member

nilmerg commented Nov 4, 2024

Any update?

@lippserd
Copy link
Member

lippserd commented Nov 4, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Nov 4, 2024
@lippserd
Copy link
Member

lippserd commented Nov 4, 2024

CLA was signed just recently for an Icinga 2 PR.

@nilmerg
Copy link
Member

nilmerg commented Nov 5, 2024

Your proposed changes are not quite correct. But they pointed me in the correct direction to actually understand the underlying problem. So I took the chance to fix this on my own, as I broke it as well originally. 😊 (#5285)

So thank you anyway :)

@nilmerg nilmerg closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants