Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test icingaredis.CreateEntities() #777

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Test icingaredis.CreateEntities() #777

merged 1 commit into from
Aug 9, 2024

Conversation

Al2Klimov
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla/signed label Jul 22, 2024
@Al2Klimov Al2Klimov force-pushed the test-icingaredis branch 2 times, most recently from 02366a0 to b19c199 Compare July 23, 2024 07:36
@oxzi oxzi added this to the 1.2.1 milestone Jul 30, 2024
oxzi
oxzi reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR. I have looked over the test code and tried it. Seems to work!

pkg/icingaredis/utils_test.go Outdated Show resolved Hide resolved
@julianbrost julianbrost requested a review from oxzi August 7, 2024 12:50
@julianbrost julianbrost merged commit 277a61d into main Aug 9, 2024
31 checks passed
@julianbrost julianbrost deleted the test-icingaredis branch August 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxzi oxzi oxzi approved these changes

Assignees
No one assigned
Labels
area/tests cla/signed
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Al2Klimov @oxzi @julianbrost