Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/icingadb: Log Icinga DB version during startup #690

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Mar 11, 2024

To better recognize the Icinga DB version used in case of errors, it is now logged at startup.

If VCS is available during build, the current commit is included.

  • Dirty VCS directory:

2024-03-11T14:36:29.317+0100 INFO icingadb Starting Icinga DB daemon (1.1.1-g0e9810c-dirty)

  • Clean VCS directory:

2024-03-11T14:38:09.664+0100 INFO icingadb Starting Icinga DB daemon (1.1.1-geed8589)

  • Build with -buildvcs=false:

2024-03-11T14:38:56.554+0100 INFO icingadb Starting Icinga DB daemon (1.1.1)

Closes #689.

To better recognize the Icinga DB version used in case of errors, it is
now logged at startup.

If VCS is available during build, the current commit is included.
- Dirty VCS directory:
> 2024-03-11T14:36:29.317+0100    INFO    icingadb        Starting Icinga DB daemon (1.1.1-g0e9810c-dirty)
- Clean VCS directory:
> 2024-03-11T14:38:09.664+0100    INFO    icingadb        Starting Icinga DB daemon (1.1.1-geed8589)
- Build with `-buildvcs=false`:
> 2024-03-11T14:38:56.554+0100    INFO    icingadb        Starting Icinga DB daemon (1.1.1)

Closes #689.
@oxzi oxzi requested a review from yhabteab March 11, 2024 13:47
@cla-bot cla-bot bot added the cla/signed label Mar 11, 2024
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM!

@julianbrost julianbrost added this to the 1.1.2 milestone Mar 11, 2024
@julianbrost julianbrost merged commit 25c6e1c into main Mar 12, 2024
31 checks passed
@julianbrost julianbrost deleted the startup-show-version-i689 branch March 12, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include app version in start-up logs
3 participants