Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump golang.org/x/net from 0.7.0 to 0.17.0 in /tests #658

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 11, 2023

Bumps golang.org/x/net from 0.7.0 to 0.17.0.

Commits
  • b225e7c http2: limit maximum handler goroutines to MaxConcurrentStreams
  • 88194ad go.mod: update golang.org/x dependencies
  • 2b60a61 quic: fix several bugs in flow control accounting
  • 73d82ef quic: handle DATA_BLOCKED frames
  • 5d5a036 quic: handle streams moving from the data queue to the meta queue
  • 350aad2 quic: correctly extend peer's flow control window after MAX_DATA
  • 21814e7 quic: validate connection id transport parameters
  • a600b35 quic: avoid redundant MAX_DATA updates
  • ea63359 http2: check stream body is present on read timeout
  • ddd8598 quic: version negotiation
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0.
- [Commits](golang/net@v0.7.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 11, 2023
@cla-bot cla-bot bot added the cla/signed label Oct 11, 2023
@julianbrost julianbrost added this to the 1.1.2 milestone Mar 8, 2024
@oxzi oxzi self-assigned this Mar 13, 2024
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change should be fine and should not affect anything.

I tried running the tests, but as before in #681 and on the main branch, TestHistory/HA fails on my local setup, even as it works in the GitHub Action.

    --- FAIL: TestHistory/HA (146.65s)
        --- FAIL: TestHistory/HA/Acknowledgement (0.92s)
            --- FAIL: TestHistory/HA/Acknowledgement/Consistency (0.00s)
        --- FAIL: TestHistory/HA/Comment (61.34s)
            --- FAIL: TestHistory/HA/Comment/Consistency (0.00s)
        --- FAIL: TestHistory/HA/Downtime (62.37s)
            --- FAIL: TestHistory/HA/Downtime/Consistency (0.00s)
        --- FAIL: TestHistory/HA/Flapping (2.76s)
            --- FAIL: TestHistory/HA/Flapping/Consistency (0.00s)
        --- FAIL: TestHistory/HA/Notification (5.48s)
        --- FAIL: TestHistory/HA/State (1.45s)
            --- FAIL: TestHistory/HA/State/Consistency (0.01s)

But due to the fact that it works in the GHA and also the main branch fails for me, this should be fine.

@julianbrost
Copy link
Contributor

That test case checks if both Icinga 2 masters produce a consistent history stream. I've seen that error a few times in GHA as well in the past. It could either be a problem in Icinga 2 (i.e. indeed generates inconsistent history) or the integration tests (like doesn't wait long enough for an event to happen, so far, I've only seen events missing completely in the full output, so it could just have taken a moment longer until it was emitted on the other master). Anyways, if you can reproduce this more reliably, we might have a chance to solve that mystery. But all of this doesn't seem to be related to this PR indeed.

@julianbrost julianbrost merged commit 1709044 into main Mar 14, 2024
31 checks passed
@julianbrost julianbrost deleted the dependabot/go_modules/tests/golang.org/x/net-0.17.0 branch March 14, 2024 09:29
@oxzi
Copy link
Member

oxzi commented Mar 14, 2024

FTR, bumping the icinga/icinga2:master Docker image from the two week old ID b18d0d1e710c to the current Image ID b4671485ab87 solved the failing TestHistory/HA tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants