cmd/icingadb-migrate: ignore icinga_downtimehistory#was_started=0 rows #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
force-pushed
the
was_started-621
branch
from
19226ae
to
2841b86
Compare
|
Did you test whether this PR still writes any downtime history? I'm missing a change in |
Such appear e.g. for scheduled but never triggered flexible Downtimes. Not triggered = no events.
Al2Klimov
force-pushed
the
was_started-621
branch
from
2841b86
to
78327c1
Compare
julianbrost
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such appear e.g. for scheduled but never triggered flexible Downtimes. Not triggered = no events.
In addition this
fixes #621
for reasons Julian described in #622 (review). (I tested that.)