Make integration tests work with Go 1.20.6 #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a security fix, Go implemented stricter checks for the Host header in the http package. This breaks the Go Docker client library [1] resulting in "http: invalid Host header" errors in our integration tests. A fix [2] was merged to the 24.0 branch, but is not yet included in a release. Therefore, this commit updates the dependency to a specific commit (`go get -u github.com/docker/[email protected]`). Once it's included in a release, this can be switched back to using a release version. [1] moby/moby#45935 [2] moby/moby#45942
|
Also affects the SQL tests, see https://github.com/Icinga/icingadb/actions/runs/5517316837/job/15288121537 for example. According to the GitHub Actions of this PR, this is fixed as well. |
lippserd
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a security fix, Go implemented stricter checks for the Host header in the http package. This breaks the Go Docker client library resulting in "http: invalid Host header" errors in our integration tests.
A fix was merged to the 24.0 branch, but is not yet included in a release. Therefore, this commit updates the dependency to a specific commit (
go get -u github.com/docker/[email protected]). Once it's included in a release, this can be switched back to using a release version.Example of a currently failing pipeline: https://github.com/Icinga/icingadb/actions/runs/5640729645/job/15277750971