schema: Add new index for customvar_flat
#617
Conversation
|
This is required, because Icinga/ipl-orm#110 will change how Icinga DB Web filters custom variables. Without an index, the then not dependent subqueries will perform a full table scan. I also played around with just an index on |
|
Pretty much the same as for #616:
But probably do one PR first as both append something to the upgrade file, you'd probably end up with a new merge conflict otherwise. |
julianbrost
force-pushed
the
fix/customvarflat-name-index-523
branch
from
e3150ce
to
d4b3dec
Compare
|
There are no new files. It's mixed up already and will be cleaned up with #602, including the schema version. |
| @@ -987,7 +987,8 @@ CREATE TABLE customvar_flat ( | |||
|
|
|||
| PRIMARY KEY (id), | |||
|
|
|||
| INDEX idx_customvar_flat_customvar_id (customvar_id) | |||
| INDEX idx_customvar_flat_customvar_id (customvar_id), | |||
| INDEX idx_customvar_flat_flatname_flatvalue (flatname, flatvalue(255)) COMMENT 'Lists filtered by custom variable' | |||
There was a problem hiding this comment.
The 255 just respects MySQL limits...
(source: @nilmerg)
| @@ -1564,13 +1564,16 @@ ALTER TABLE customvar_flat ALTER COLUMN customvar_id SET STORAGE PLAIN; | |||
| ALTER TABLE customvar_flat ALTER COLUMN flatname_checksum SET STORAGE PLAIN; | |||
|
|
|||
| CREATE INDEX idx_customvar_flat_customvar_id ON customvar_flat(customvar_id); | |||
| CREATE INDEX idx_customvar_flat_flatname_flatvalue ON customvar_flat(flatname, flatvalue); | |||
There was a problem hiding this comment.
... so we don't need to emulate it here.
There was a problem hiding this comment.
Indeed. I tested with a 32k character long flatvalue, PostgreSQL was happy.
resolves #523
postgres changes still tbd