Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger#object_filter: restrict Logger to messages referring to specific objects #9844

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Logger#object_filter: restrict Logger to messages referring to specific objects #9844

wants to merge 15 commits into from

Commits on Aug 11, 2023

  1. Introduce Logger#object_filter

    @Al2Klimov
    Al2Klimov committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f59082d View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Logger#{OnAllConfigLoaded,SetObjectFilter}(): warn on missing objects… 

    … for
    @Al2Klimov
    Al2Klimov committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9693663 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Cache actual Logger#object_filter objects in Logger#m_ObjectFilterCache

    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    27413d5 View commit details
    Browse the repository at this point in the history

  2. Introduce ObjectImpl<ConfigObject>#GetParentsAffectingLogging()

    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    7914d8e View commit details
    Browse the repository at this point in the history

  3. Disallow Downtime#config_owner modification 

    This attribute is used only by ScheduledDowntime anyway
and is a relation declarator such as host_name, service_name.
    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    a3f8d84 View commit details
    Browse the repository at this point in the history

  4. Forbid Zone#endpoints modification 

    The cluster tree can't be runtime-altered anyway.
    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    53f881b View commit details
    Browse the repository at this point in the history

  5. parent_affecting_logging: a zone affects everything in it

    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    1ce044c View commit details
    Browse the repository at this point in the history

  6. parent_affecting_logging: a group affects everything in it

    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    06ea999 View commit details
    Browse the repository at this point in the history

  7. parent_affecting_logging: a config object affects everything applied … 

    …to it

See the currently supported apply rules.
    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    67fb214 View commit details
    Browse the repository at this point in the history

  8. parent_affecting_logging: a config object affects everything function… 

    …ally depending on it
    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d98bb31 View commit details
    Browse the repository at this point in the history

  9. ConfigObject#OnAllConfigLoaded(): build m_AllParentsAffectingLogging … 

    …cache

recursively from ConfigObject#GetParentsAffectingLogging().
    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    2a14803 View commit details
    Browse the repository at this point in the history

  10. Merge Log#Log() methods

    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    eb1261e View commit details
    Browse the repository at this point in the history

  11. Log#Log(): require passing one involved object

    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    73e9b52 View commit details
    Browse the repository at this point in the history

  12. [TODO: REVERT] Repair GHA for now

    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    0cecad6 View commit details
    Browse the repository at this point in the history

  13. Log#~Log(): skip messages based on Logger#m_ObjectFilterCache & Confi… 

    …gObject#m_AllParentsAffectingLogging

If Logger#object_filter is set, but doesn't intersect with
ConfigObject#m_AllParentsAffectingLogging, drop the message.
    @Al2Klimov
    Al2Klimov committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8c3bfd0 View commit details
    Browse the repository at this point in the history