Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance documentation regarding internal icinga config sync check #10101

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ChrLau
Copy link

@ChrLau ChrLau commented Jul 23, 2024

Hi,

I had the problem that I converted my non-distributed monitoring to a distributed one. That worked fine for years, but due to a new NotificationCommand I noticed that I had defined a necessary Token inside /etc/icinga2/constants.conf file, which of course is not synced to the satellites/agents.
I only noticed this a few weeks after these changes, as another new service check wasn't being rolled out to the agents.
(Small homelab environment, not many changes are happening.)

After figuring this all out I learned only through the Community forum that the internal icinga CheckCommand checks for successful config syncs IF it is executed on the satellites/agents. Which was not the case in my scenario as I didn't properly migrate that service for a redundant setup.

However.. The documentation on this is very sparse. The config file sync check is only named indirectly and you only understand what that means when you already know what the CheckCommand does. - Not really helpful.
Also the troubleshooting section made no mention of that.

With this commit I try to fix these 2 minor issues. Hoping other people will spot their errors faster than me. ;-)

Explicitly name the config-sync check feature of the icinga check, as before this was a little bit too undocumented making it unknown to me.
Also mention where the check has to executed in order to bring the desired results.
Add 4h typical error point for configuration stored outside of /etc/icinga2/zones.d. For when a non-distributed setup was migrated to a distributed setup.
Also link to the internal icinga CheckCommand to promote its existance.
Remove "-" from link
@cla-bot cla-bot bot added the cla/signed label Jul 23, 2024
@ChrLau
Copy link
Author

ChrLau commented Jul 23, 2024

I wasn't sure if I should mention the icinga CheckCommand in the technical concept describing the config sync. However I'm pleased to do so if you think it makes sense: https://icinga.com/docs/icinga-2/latest/doc/19-technical-concepts/#config-sync

@oxzi oxzi added the area/documentation End-user or developer help label Jul 24, 2024
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for using Icinga all these years and trying to improve the experience of other users.

I have added some small notes, please take a look.

Edit: Please add yourself to the AUTHORS file with the username and email used in your commit, as noted by the check https://github.com/Icinga/icinga2/actions/runs/10063806426/job/27848891798?pr=10101.

doc/10-icinga-template-library.md Outdated Show resolved Hide resolved
doc/15-troubleshooting.md Outdated Show resolved Hide resolved
doc/15-troubleshooting.md Outdated Show resolved Hide resolved
Add myself to AUTHORS
@ChrLau ChrLau marked this pull request as draft July 24, 2024 10:19
@ChrLau ChrLau marked this pull request as ready for review July 24, 2024 10:22
@ChrLau
Copy link
Author

ChrLau commented Jul 24, 2024

Hi @oxzi

the changes are fine for me.
And I added myself to the AUTHORS file.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation End-user or developer help cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants