Reject infinite performance data values #10077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
reviewed
Jun 10, 2024
lib/base/perfdatavalue.cpp
Outdated
| @@ -259,6 +259,10 @@ PerfdataValue::Ptr PerfdataValue::Parse(const String& perfdata) | |||
|
|
|||
| double value = Convert::ToDouble(tokens[0].SubStr(0, pos)); | |||
|
|
|||
| if (value == INFINITY || value == - INFINITY) { | |||
There was a problem hiding this comment.
There are special functions for such checks like std::isinf(). A related function like std::isfinite() or std::isnormal() might be even better suited here as it excludes more edge cases (I haven't checked if subnormal numbers would be a problem, that seems to be the only difference between these two functions).
There was a problem hiding this comment.
Please excuse my C. Those functions do seem more appropriate and sane to use.
I will change that accordingly. Thank you for the tip
Some fault monitoring plugins may return "inf" or "-inf" as values due to a failure to initialize or other errors. This patch introduces a check on whether the parse value is infinite (or negative infinite) and rejects the data point if that is the case. The reasoning here is: There is no possible way a value of "inf" is ever a true measuring or even useful. Furthermore, when passed to the performance data writers, it may be rejected by the backend and lead to further complications.
RincewindsHat
force-pushed
the
reject_invalid_perfdata
branch
from
310efe0
to
b8c6899
Compare
|
@julianbrost should be fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fault monitoring plugins may return "inf" or "-inf" as values due to a failure to initialize or other errors.
This patch introduces a check on whether the parse value is infinite (or negative infinite) and rejects the data point if that is the case.
The reasoning here is: There is no possible way a value of "inf" is ever a true measuring or even useful. Furthermore, when passed to the performance data writers, it may be rejected by the backend and lead to further complications.
fixes #10073