Test com.Cond #46
Open
Test com.Cond #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
added
enhancement
oxzi
requested changes
Aug 14, 2024
Comment on lines
+28
to
+31
| case <-done: | ||
| require.Fail(t, "cond should still not be closed") | ||
| case <-cond.Done(): | ||
| require.Fail(t, "cond should not be closed for round 2, yet") |
There was a problem hiding this comment.
Is there a difference between those two cases? Both cases check the value of cond.Done(), returning cond.done which doesn't change over the time. Unless I'm missing something, this is the exact same channel.
There was a problem hiding this comment.
What you digged out is an implementation detail which tests don't rely on.
| done := cond.Done() | ||
| wait := cond.Wait() | ||
|
|
||
| require.NoError(t, cond.Close()) |
There was a problem hiding this comment.
In its current implementation, Close() always returns nil, even when the API doc states otherwise.
Comment on lines
+63
to
+70
| select { | ||
| case _, ok := <-cond.Done(): | ||
| if ok { | ||
| require.Fail(t, "new cond-closed channel should be closed") | ||
| } | ||
| case <-time.After(time.Second / 10): | ||
| require.Fail(t, "cond should be still closed") | ||
| } |
There was a problem hiding this comment.
Again, same .done channel as already checked in the select above.
There was a problem hiding this comment.
What you digged out is an implementation detail which tests don't rely on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.