Test structify.MakeMapStructifier() #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxzi
reviewed
Sep 6, 2024
Al2Klimov
force-pushed
the
test-structify
branch
from
c99c4f3
to
37f5d94
Compare
oxzi
approved these changes
Sep 27, 2024
lippserd
requested changes
Sep 27, 2024
structify/structify_test.go
Outdated
| func TestMakeMapStructifier(t *testing.T) { | ||
| subtests := []struct { | ||
| name string | ||
| tag string |
There was a problem hiding this comment.
tag is actually hard-coded, so it does not make sense to always specify it. If the empty test is the only case in which it must be the empty string, make a separate test.
structify/structify_test.go
Outdated
| Inline stringTest `test:",inline"` | ||
| }{Inline: stringTest{S: "foobar"}}}, | ||
| {"missing_inline", "test", nil, map[string]any{"s": "foobar"}, false, &struct { | ||
| Inline stringTest |
There was a problem hiding this comment.
What about an actual test for embedded structs?
structify/structify_test.go
Outdated
| {"dash_tag", "test", nil, map[string]any{"s": "foobar"}, false, &struct { | ||
| S string `test:"-"` | ||
| }{}}, | ||
| {"missing", "test", nil, nil, false, &stringTest{}}, |
structify/structify_test.go
Outdated
| error bool | ||
| output any | ||
| }{ | ||
| {"empty", "", nil, nil, false, &struct{}{}}, |
There was a problem hiding this comment.
This wall of code is barely readable, and testing is about what is actually being tested, so please make it readable instead of always trying to save lines at all costs.
Al2Klimov
force-pushed
the
test-structify
branch
from
37f5d94
to
deb4a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.