Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function and keyword argument name deprecations #255

Merged
merged 1 commit into from
Apr 4, 2020
Merged

Conversation

mtfishman
Copy link
Member

This implements the name changes proposed in #245.

@codecov-io
Copy link

codecov-io commented Apr 3, 2020

Codecov Report

Merging #255 into master will decrease coverage by 0.06%.
The diff coverage is 85.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   79.83%   79.77%   -0.07%     
==========================================
  Files          50       50              
  Lines        4805     4830      +25     
==========================================
+ Hits         3836     3853      +17     
- Misses        969      977       +8     
Impacted Files Coverage Δ
src/decomp.jl 95.94% <ø> (ø)
src/Tensors/linearalgebra.jl 80.83% <70.58%> (-1.70%) ⬇️
src/Tensors/truncate.jl 93.02% <80.00%> (-4.28%) ⬇️
src/mps/mpo.jl 99.09% <93.33%> (-0.30%) ⬇️
src/mps/mps.jl 99.26% <100.00%> (ø)
src/tagset.jl 89.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374858b...61e8f16. Read the comment docs.

@emstoudenmire
Copy link
Collaborator

Looks good (fixes #245)

@emstoudenmire emstoudenmire merged commit 6d04bbb into master Apr 4, 2020
@emstoudenmire emstoudenmire deleted the api_changes branch April 4, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants