Skip to content

Update constructors #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Update constructors #17

merged 1 commit into from
Mar 7, 2025

Conversation

mtfishman
Copy link
Member

This updates the constructors for DiagonalArray to match the new style and interfaces of SparseArrayDOK (ITensor/SparseArraysBase.jl#43) and BlockSparseArray (ITensor/BlockSparseArrays.jl#68).

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 57.57576% with 14 lines in your changes missing coverage. Please review.

Project coverage is 80.50%. Comparing base (ccd35c2) to head (4d4ccd4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/diagonalarray/diagonalarray.jl 57.57% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   80.51%   80.50%   -0.02%     
==========================================
  Files          11       11              
  Lines         154      159       +5     
==========================================
+ Hits          124      128       +4     
- Misses         30       31       +1     
Flag Coverage Δ
docs 66.24% <51.51%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman merged commit 81dd30b into main Mar 7, 2025
11 of 13 checks passed
@mtfishman mtfishman deleted the update_constructors branch March 7, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant