Skip to content

Fix vector show #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 10, 2025
Merged

Fix vector show #79

merged 8 commits into from
Mar 10, 2025

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Mar 7, 2025

Along with ITensor/SparseArraysBase.jl#45 and ITensor/SparseArraysBase.jl#46, this fixes #77.

To-do:

  • Add tests.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.24%. Comparing base (10f6ebf) to head (5b32818).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   76.22%   76.24%   +0.02%     
==========================================
  Files          28       28              
  Lines        1081     1082       +1     
==========================================
+ Hits          824      825       +1     
  Misses        257      257              
Flag Coverage Δ
docs 16.24% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
Copy link
Member Author

This now relies on #46 for tests to pass.

@mtfishman mtfishman changed the title [WIP] Fix vector show Fix vector show Mar 10, 2025
@mtfishman mtfishman marked this pull request as ready for review March 10, 2025 14:07
@mtfishman mtfishman closed this Mar 10, 2025
@mtfishman mtfishman reopened this Mar 10, 2025
@mtfishman mtfishman closed this Mar 10, 2025
@mtfishman mtfishman reopened this Mar 10, 2025
@mtfishman mtfishman merged commit 56f7aea into main Mar 10, 2025
22 of 41 checks passed
@mtfishman mtfishman deleted the vec_show branch March 10, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] BlockSparseVector displays sparse zero as 0 instead of .
1 participant