Skip to content

use BlockedTuple in splitdims #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

ogauthe
Copy link
Collaborator

@ogauthe ogauthe commented Feb 21, 2025

Adapt BlockSparseArrays to the new TensorAlgebra.splitdims interface defined in ITensor/TensorAlgebra.jl#33

The new code removes the need for reducewhile.jl. I commented the include but did not delete the code as we may use it somewhere else or split it to its own library.

@ogauthe ogauthe changed the title use BlockedTuple in splitidims use BlockedTuple in splitdims Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 24.79%. Comparing base (42ec520) to head (83c179a).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...sorAlgebraExt/BlockSparseArraysTensorAlgebraExt.jl 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (42ec520) and HEAD (83c179a). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (42ec520) HEAD (83c179a)
6 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #55       +/-   ##
===========================================
- Coverage   75.15%   24.79%   -50.37%     
===========================================
  Files          30       29        -1     
  Lines        1111     1097       -14     
===========================================
- Hits          835      272      -563     
- Misses        276      825      +549     
Flag Coverage Δ
docs 24.79% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogauthe
Copy link
Collaborator Author

ogauthe commented Apr 2, 2025

Closed as we now plan a new interface based on matricize / unmatricize

@ogauthe ogauthe closed this Apr 2, 2025
@ogauthe ogauthe deleted the blockedaxes branch April 10, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant