-
Notifications
You must be signed in to change notification settings - Fork 2
Noncontiguous slicing #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 73.27% 73.90% +0.63%
==========================================
Files 28 29 +1
Lines 1216 1261 +45
==========================================
+ Hits 891 932 +41
- Misses 325 329 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a little bit hacky but fixes some bugs and doesn't require modifying other code much. At some point we should probably go through the slicing/SubArray logic more holistically and try to clean it up (in particular, I think we can be more systematic about how we distinguish between blockwise vs. non-blockwise slices). |
No description provided.