Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 E2E: be compatible with legacy services #7134

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jan 29, 2025

What do these changes do?

  • 🎨 be compatible with legacy services when opening study

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jan 29, 2025
@matusdrobuliak66 matusdrobuliak66 added the e2e Bugs found by or related to the end-2-end testing label Jan 29, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review January 29, 2025 12:09
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (194d225) to head (a58785a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7134      +/-   ##
==========================================
+ Coverage   84.57%   87.68%   +3.11%     
==========================================
  Files        1598     1628      +30     
  Lines       61728    63685    +1957     
  Branches     2053     2053              
==========================================
+ Hits        52206    55843    +3637     
+ Misses       9199     7505    -1694     
- Partials      323      337      +14     
Flag Coverage Δ
integrationtests 64.68% <ø> (+2.89%) ⬆️
unittests 85.97% <ø> (+1.86%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.33% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.39% <ø> (ø)
pkg_service_integration 70.18% <ø> (ø)
pkg_service_library 74.14% <ø> (ø)
pkg_settings_library 90.71% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (+19.74%) ⬆️
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (∅)
catalog 90.33% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.92% <ø> (ø)
director_v2 91.27% <ø> (+5.73%) ⬆️
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.95% <ø> (ø)
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.20% <ø> (+5.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194d225...a58785a. Read the comment docs.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Jan 29, 2025
Copy link
Contributor

mergify bot commented Jan 29, 2025

Restarted CI due to failing tests

@GitHK
Copy link
Contributor

GitHK commented Jan 29, 2025

@Mergifyio queue

Copy link
Contributor

mergify bot commented Jan 29, 2025

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@GitHK
Copy link
Contributor

GitHK commented Jan 29, 2025

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jan 29, 2025

refresh

✅ Pull request refreshed

Copy link
Contributor

mergify bot commented Jan 29, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Jan 29, 2025

Restarted CI due to failing tests

@matusdrobuliak66
Copy link
Contributor Author

https://github.com/Mergifyio queue

Copy link
Contributor

mergify bot commented Jan 29, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8bed900

@mergify mergify bot merged commit 8bed900 into ITISFoundation:master Jan 29, 2025
95 checks passed
Comment on lines +271 to +272
autoscaled = request.config.getoption("--service-is-legacy")
return TypeAdapter(bool).validate_python(autoscaled)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoscaled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants