Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ E2E: provide a requirements file without playwright installed #7050

Merged
merged 2 commits into from
Jan 16, 2025
Merged

♻️ E2E: provide a requirements file without playwright installed #7050

merged 2 commits into from
Jan 16, 2025

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 16, 2025 •
edited
Loading

What do these changes do?

  • provide a requirement listing without playwright installed for CI builds that use a base image where playwright is already pre-installed

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Jan 16, 2025
@sanderegg sanderegg added this to the Singularity milestone Jan 16, 2025
@sanderegg sanderegg self-assigned this Jan 16, 2025
matusdrobuliak66
matusdrobuliak66 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sanderegg sanderegg force-pushed the e2e-provide-dependencies-without-installing-playwright branch from e9626a2 to 21d76a6 Compare January 16, 2025 15:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit 79d19bf into ITISFoundation:master Jan 16, 2025
55 checks passed
@sanderegg sanderegg deleted the e2e-provide-dependencies-without-installing-playwright branch January 16, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@sanderegg sanderegg

Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.
4 participants
@sanderegg @GitHK @pcrespov @matusdrobuliak66