-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Database: added comp_tasks submit column back for legacy services (🗃️) #7003
🐛 Database: added comp_tasks submit column back for legacy services (🗃️) #7003
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7003 +/- ##
==========================================
+ Coverage 86.92% 88.40% +1.48%
==========================================
Files 1630 1405 -225
Lines 64378 56255 -8123
Branches 2035 893 -1142
==========================================
- Hits 55959 49734 -6225
+ Misses 8086 6366 -1720
+ Partials 333 155 -178
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
packages/postgres-database/src/simcore_postgres_database/models/comp_tasks.py
Show resolved
Hide resolved
f3e5484
to
924c072
Compare
924c072
to
378269e
Compare
Quality Gate passedIssues Measures |
What do these changes do?
Legacy services that have a
node ports
package integrated still rely on the old schemas of the comp_tasks table.This PR re-adds the deprecated column with a default of 1st Jan 1900.
Related issue/s
How to test
Dev-ops checklist