-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ web-api: share tags #6998
✨ web-api: share tags #6998
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6998 +/- ##
==========================================
+ Coverage 85.52% 88.19% +2.66%
==========================================
Files 1630 1429 -201
Lines 64379 56953 -7426
Branches 2035 945 -1090
==========================================
- Hits 55063 50227 -4836
+ Misses 8982 6557 -2425
+ Partials 334 169 -165
Continue to review full report in Codecov by Sentry.
|
services/web/server/src/simcore_service_webserver/tags/_service.py
Outdated
Show resolved
Hide resolved
Still |
sorry. I forgot to include one more feature ... will reassign |
packages/postgres-database/src/simcore_postgres_database/utils_tags.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_tags.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_tags.py
Outdated
Show resolved
Hide resolved
098305a
to
cf441b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
packages/postgres-database/src/simcore_postgres_database/utils_tags_sql.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Quality Gate passedIssues Measures |
We will follow up on some comments during the review in #7011 |
What do these changes do?
tags
projects
, etc): usestags/{tag_id}/groups
subresource to share tagtag_id
with a groupgroup_id
.group_id=1
) cannot be donegroup_id
is associated to `product_name)) only allowed to TESTERS, POs and ADMIN userstags
domain as controller (_rest
)-service (_service
)-repository (will be moved from postgres-database library in subsequent PR)Related issue/s
How to test
Dev-ops checklist
None