Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Frontend] bugfix: open folder after deleting file #6997

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 3, 2025

What do these changes do?

Before, after deleting the file the current folder wouldn't stay selected, this PR fixes it.

Bonus:

Fixed glitch with the "Drop here" widget spotted while debugging with @giancarloromeo

SetFolderAfterDElete

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jan 3, 2025
@odeimaiz odeimaiz added this to the Event Horizon milestone Jan 3, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Jan 3, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 3, 2025 15:17
@odeimaiz odeimaiz enabled auto-merge (squash) January 3, 2025 15:17
Copy link

sonarqubecloud bot commented Jan 3, 2025

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

THOUGHT/QUESTION: does it make sense to consider trash for data as well?

@odeimaiz
Copy link
Member Author

odeimaiz commented Jan 5, 2025

thx

THOUGHT/QUESTION: does it make sense to consider trash for data as well?

Ufff... I guess it would be very hard to implement, but it would make sense from the user's perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setFolder after deleting file from Service data
3 participants