🎨🐛 [Frontend] Copyright with current year #6996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
odeimaiz
added
t:enhancement
odeimaiz
requested review from
giancarloromeo,
GitHK,
pcrespov,
sanderegg and
matusdrobuliak66
odeimaiz
changed the title
pcrespov
reviewed
Jan 3, 2025
| @@ -205,6 +205,27 @@ qx.Class.define("osparc.product.Utils", { | |||
| return "REGISTER"; | |||
| }, | |||
|
|
|||
| getCopyrightLink: function() { | |||
There was a problem hiding this comment.
Some thoughts:
what is copyright date used for?
- the year in a copyright footnote is a crucial piece of information that identifies the creation or publication date of the work, thereby clarifying its copyright status and duration.
- The year indicates when the copyright was claimed or began.
- The copyright duration in most countries is based on the life of the author plus a specific number of years (e.g., 70 years in the US and EU). However, for corporate or anonymous works, it may be a fixed term starting from the date of publication. The year helps calculate when the copyright will expire.
Therefore:
- There is no need to change the copyright to the latest year all the time
- I understand that this provides an easy and fast fix but I think it is a bad practice to override the information provided by the PO in the backend. Some alternatives are:
-
- Provide a
product.vendor.copyrightnote as a template string e.g.$(year) ITIS-Foundationis variable but2024 ITIS-Foundationis fixed year
- Provide a
-
- Compose copyright note from vendor fields instead of a having a dedicated entry for it. Therefore we drop
copyrightand add an optionalcopyrightYearand if not provided you add the latest.
- Compose copyright note from vendor fields instead of a having a dedicated entry for it. Therefore we drop
-
There was a problem hiding this comment.
I honestly don't have a strong opinion on this one, it was reported in the team chat and this was a fix. Shall we leave to the POs?
There was a problem hiding this comment.
I do not even think this might be an issue if you ask the POs.
I would ask. Write here the answer (and who answered you) and resolve it fast within this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In order to keep up with the current year in the copyright text, in this PR the frontend tunes the copyright text coming from the vendor's information:
DB:
Frontend:
Related issue/s
How to test
Dev-ops checklist