Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨adding endpoints to create and remove docker networks to director-v2 #6991

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 23, 2024

What do these changes do?

In order to extract the dynamic-scheduler functionality from director-v2 the director-v2 must expose an interface which is able to create and remove docker networks (focus of this PR) and docker services (different PR).

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.52%. Comparing base (493488c) to head (ffb5791).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6991      +/-   ##
==========================================
- Coverage   87.02%   86.52%   -0.50%     
==========================================
  Files        1621     1317     -304     
  Lines       63993    55092    -8901     
  Branches     2035      899    -1136     
==========================================
- Hits        55688    47667    -8021     
+ Misses       7972     7288     -684     
+ Partials      333      137     -196     
Flag Coverage Δ
integrationtests 68.37% <84.90%> (+3.78%) ⬆️
unittests 85.23% <100.00%> (+0.19%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.55% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.46% <100.00%> (+0.04%) ⬆️
dynamic_scheduler 97.19% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.56% <ø> (ø)
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 79.87% <ø> (-4.55%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493488c...ffb5791. Read the comment docs.

@GitHK GitHK changed the title Pr osparc director v2 endpoint network create remove ✨adding endpoints to create and remove docker networks to director-v2 Dec 23, 2024
@GitHK GitHK self-assigned this Dec 23, 2024
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Dec 23, 2024
@GitHK GitHK added this to the Event Horizon milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant