-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Sync nodes when patching #6973
🐛 Sync nodes when patching #6973
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6973 +/- ##
==========================================
- Coverage 86.99% 81.28% -5.71%
==========================================
Files 1621 631 -990
Lines 63939 30560 -33379
Branches 2033 262 -1771
==========================================
- Hits 55624 24842 -30782
+ Misses 7981 5658 -2323
+ Partials 334 60 -274
Continue to review full report in Codecov by Sentry.
|
services/web/server/src/simcore_service_webserver/projects/projects_api.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_api.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_api.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! thanks! don't forget to add in your case:
- resolves CASE_LINK or fixes CASE_LINK,
This will auto fix it and link the PR to the issue automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would also appreciate a test.
Quality Gate passedIssues Measures |
What do these changes do?
Whenever a node is patched - in particular
inputs
and/oroutputs
get modified - all the nodes in the project need to be checked for state changes.The issue was more evident trying to reproduce #6505.
Related issue/s
How to test
Dev-ops checklist