Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Sync nodes when patching #6973

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Dec 17, 2024

What do these changes do?

Whenever a node is patched - in particular inputs and/or outputs get modified - all the nodes in the project need to be checked for state changes.

The issue was more evident trying to reproduce #6505.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Dec 17, 2024
@giancarloromeo giancarloromeo added bug buggy, it does not work as expected a:webserver issue related to the webserver service labels Dec 17, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (48d3fba) to head (89c9b80).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (48d3fba) and HEAD (89c9b80). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (48d3fba) HEAD (89c9b80)
unittests 30 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6973      +/-   ##
==========================================
- Coverage   86.99%   81.28%   -5.71%     
==========================================
  Files        1621      631     -990     
  Lines       63939    30560   -33379     
  Branches     2033      262    -1771     
==========================================
- Hits        55624    24842   -30782     
+ Misses       7981     5658    -2323     
+ Partials      334       60     -274     
Flag Coverage Δ
integrationtests 64.89% <0.00%> (-0.03%) ⬇️
unittests 78.35% <100.00%> (-7.24%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.80% <ø> (-12.61%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 86.20% <100.00%> (+1.76%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d3fba...89c9b80. Read the comment docs.

@giancarloromeo giancarloromeo marked this pull request as ready for review December 17, 2024 14:36
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! thanks! don't forget to add in your case:

  • resolves CASE_LINK or fixes CASE_LINK,
    This will auto fix it and link the PR to the issue automatically

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would also appreciate a test.

@giancarloromeo giancarloromeo enabled auto-merge (squash) December 18, 2024 14:58
@giancarloromeo giancarloromeo merged commit e9eec69 into ITISFoundation:master Dec 18, 2024
86 of 93 checks passed
@giancarloromeo giancarloromeo deleted the is6505/sync-nodes-when-patching branch December 20, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update file in filepicker doesn't force pipeline rerun
5 participants