🐛Autoscaling: Warm buffers do not replace hot buffers #6962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
requested review from
giancarloromeo,
GitHK,
mrnicegyu11,
mguidon,
YuryHrytsuk and
bisgaard-itis
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6962 +/- ##
==========================================
+ Coverage 88.10% 88.16% +0.06%
==========================================
Files 1592 1585 -7
Lines 62326 62145 -181
Branches 2012 2012
==========================================
- Hits 54912 54792 -120
+ Misses 7078 7017 -61
Partials 336 336
Continue to review full report in Codecov by Sentry.
|
pcrespov
approved these changes
Dec 13, 2024
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Outdated
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Show resolved
Hide resolved
|
bisgaard-itis
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In case both warm and hot buffers are used for specific instance type, the warm buffers were not prioritized over launching a fresh instance. This would lead to inneficiencies and also additional costs as the warm buffer would only be used if more users than hot buffers were starting a service at the same time.
Related issue/s
How to test
Dev-ops checklist