Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Avatar for users with hidden email #6952

Merged
merged 10 commits into from
Dec 12, 2024
Merged

🎨 [Frontend] Avatar for users with hidden email #6952

merged 10 commits into from
Dec 12, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Dec 11, 2024 •
edited
Loading

What do these changes do?

Use the username, which is always available, to generate a thumbnail with the initials:

Bonus:

  • Fix: open Market
  • Fix: get classifiers

image

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Dec 11, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Dec 11, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Dec 11, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) December 11, 2024 16:28
pcrespov
pcrespov approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

services/static-webserver/client/source/class/osparc/utils/Avatar.js Show resolved Hide resolved
services/static-webserver/client/source/class/osparc/utils/Avatar.js Outdated Show resolved Hide resolved
services/static-webserver/client/source/class/osparc/store/Store.js Show resolved Hide resolved
sanderegg
sanderegg reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit c0df260 into ITISFoundation:master Dec 12, 2024
55 checks passed
@odeimaiz odeimaiz deleted the enh/avatar-for-null-emails branch December 12, 2024 07:28
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 12, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@GitHK GitHK Awaiting requested review from GitHK

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @jsaq007 @pcrespov @sanderegg