Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Frontend] Fix: e2e-portal's browser doesn't support replaceAll #6932

Merged
merged 1 commit into from
Dec 10, 2024
Merged

🐛 [Frontend] Fix: e2e-portal's browser doesn't support replaceAll #6932

merged 1 commit into from
Dec 10, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Dec 10, 2024 •
edited by sanderegg
Loading

What do these changes do?

Use replace instead of replaceAll
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll#browser_compatibility

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Dec 10, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) December 10, 2024 14:33
@odeimaiz odeimaiz added bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing a:frontend issue affecting the front-end (area group) labels Dec 10, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Dec 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sanderegg
sanderegg approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sanderegg sanderegg disabled auto-merge December 10, 2024 14:47
@sanderegg sanderegg merged commit bf07906 into ITISFoundation:master Dec 10, 2024
52 of 54 checks passed
@odeimaiz odeimaiz deleted the fix/replace-replaceall branch December 10, 2024 14:48
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 11, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
3 participants
@odeimaiz @sanderegg @matusdrobuliak66