Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒️ Remove sensitive data from logs #6905

Merged

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Dec 4, 2024

What do these changes do?

Hide sensitive data when an exception is raised.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added the security Pull requests that address a security vulnerability label Dec 4, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Dec 4, 2024
@giancarloromeo giancarloromeo self-assigned this Dec 4, 2024
@giancarloromeo giancarloromeo changed the title 🔒️ Hide sensitive data from logs 🔒️ Remove sensitive data from logs Dec 4, 2024
Copy link

sonarqubecloud bot commented Dec 4, 2024

@giancarloromeo giancarloromeo marked this pull request as ready for review December 4, 2024 15:35
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.35%. Comparing base (dc28926) to head (27b460b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6905      +/-   ##
==========================================
+ Coverage   88.32%   88.35%   +0.02%     
==========================================
  Files        1553     1189     -364     
  Lines       61191    51421    -9770     
  Branches     2095      980    -1115     
==========================================
- Hits        54050    45432    -8618     
+ Misses       6809     5799    -1010     
+ Partials      332      190     -142     
Flag Coverage Δ
integrationtests 65.06% <ø> (-0.09%) ⬇️
unittests 86.17% <33.33%> (-0.34%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 76.06% <33.33%> (-0.02%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent ∅ <ø> (∅)
api_server 89.81% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.40% <ø> (-0.09%) ⬇️
director_v2 91.36% <ø> (-0.09%) ⬇️
dynamic_scheduler 97.01% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.77% <ø> (ø)
resource_usage_tracker 89.07% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc28926...27b460b. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@giancarloromeo giancarloromeo enabled auto-merge (squash) December 4, 2024 17:50
@giancarloromeo giancarloromeo merged commit 8817832 into ITISFoundation:master Dec 4, 2024
93 of 99 checks passed
@giancarloromeo giancarloromeo deleted the hide-sensitive-data branch December 4, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs contain sensitive data
4 participants