Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Maintenance: bump all dependencies for dynamic-sidecar service #6841

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 26, 2024

What do these changes do?

Updated all packages of the dynamic-sidecar.
Fixed issues caused by Inotify changes in original package.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Nov 26, 2024
@GitHK GitHK added t:maintenance Some planned maintenance work a:dynamic-sidecar dynamic-sidecar service labels Nov 26, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 26, 2024
@GitHK GitHK changed the title ⬆️ Maintenance: bump all dependencies for agent service ⬆️ Maintenance: bump all dependencies for dynamic-sidecar service Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.19%. Comparing base (125a290) to head (5d3cad1).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (125a290) and HEAD (5d3cad1). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (125a290) HEAD (5d3cad1)
unittests 29 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6841       +/-   ##
===========================================
- Coverage   86.39%   71.19%   -15.20%     
===========================================
  Files        1513      619      -894     
  Lines       59633    30921    -28712     
  Branches     2166      318     -1848     
===========================================
- Hits        51521    22015    -29506     
- Misses       7782     8846     +1064     
+ Partials      330       60      -270     
Flag Coverage Δ
integrationtests 64.77% <33.33%> (-0.02%) ⬇️
unittests 88.80% <77.77%> (+2.62%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.04% <ø> (+14.50%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.75% <77.77%> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.55% <ø> (-29.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125a290...5d3cad1. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review November 27, 2024 08:31
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitHK The report you generated is wrong. it shows 0 changes.!
Make sure you do not have the old requirements/tools/changes.igore.log in place. clean all cache fiels there and rerun the report

@GitHK GitHK enabled auto-merge (squash) November 27, 2024 10:20
@GitHK GitHK merged commit 83a08e7 into ITISFoundation:master Nov 27, 2024
85 of 90 checks passed
@GitHK GitHK deleted the pr-osparc-bump-dynamic-sidecar-dependencies branch November 27, 2024 10:44
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants