♻️ aiohttp deprecation: Using web.json_response to return 2XX responses instead of raising HttpException
#6829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
changed the title
aiohttp deprecation: Using web.json_response to return 2XX responses instead of raising HttpException
pcrespov
requested review from
giancarloromeo,
GitHK,
matusdrobuliak66 and
bisgaard-itis
giancarloromeo
approved these changes
Nov 26, 2024
sanderegg
approved these changes
Nov 26, 2024
services/storage/src/simcore_service_storage/handlers_simcore_s3.py
Outdated
Show resolved
Hide resolved
GitHK
approved these changes
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6829 +/- ##
==========================================
- Coverage 88.14% 88.14% -0.01%
==========================================
Files 1513 1513
Lines 59634 59632 -2
Branches 2166 2166
==========================================
- Hits 52562 52560 -2
Misses 6741 6741
Partials 331 331
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
pcrespov
force-pushed
the
fix/return-web-json
branch
from
d56a6cd to
9ae6010
Compare
pcrespov
force-pushed
the
fix/return-web-json
branch
from
71a24d8 to
966110a
Compare
|
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
aiohttpdeprecated returningHttpException. Moreover, raising non-error creates false negatives as in the example below where201(Created) was shown as an error in our tracingJaeger captures these exceptions as errors in storage:
Related issue/s
aiohttpdeprecation: Usingweb.json_responseto return2XXresponses instead of raisingHttpException#6563How to test
Dev-ops
None